Fix checkpoint restore button showing empty floating window #8647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue where checkpoint restore button shows empty popover content - When portalContainer is undefined, PopoverContent now renders normally without portal - Only pass container prop when portalContainer is available - Resolves issue #8646
dosubot
bot
added
size:XS
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #8646.
Problem
The checkpoint restore button was showing an empty floating window instead of the proper restore menu content.
Root Cause
The issue was in the
CheckpointMenucomponent where thePopoverContentwas always receiving acontainerprop, even whenportalContainerwasundefined. When the portal container is undefined (because the "roo-portal" element doesn't exist or isn't found), passing it to thecontainerprop causes the popover to render as an empty floating window.Solution
Changed the prop passing from:
to:
This ensures the
containerprop is only passed whenportalContaineris truthy, allowing the popover to render normally when no portal container is available.Testing
Feedback and guidance are welcome!
Important
Fixes empty floating window in
CheckpointMenuby conditionally passingcontainerprop toPopoverContent.CheckpointMenuby conditionally passingcontainerprop toPopoverContentonly whenportalContaineris truthy.This description was created by
for 33f5d5c. You can customize this summary. It will automatically update as commits are pushed.